FATAL ERROR: v8::ToLocalChecked Empty MaybeLocal

Why this is a good first issue

The issue involves preventing crashes when builtin prototypes are modified, which requires careful handling in the V8 engine.

AI Summary

The issue involves a crash when builtin prototypes like Array.prototype are modified, specifically when using child_process.exec. The task is to prevent the crash without making invasive changes, focusing on improving UX rather than fixing a bug. The main challenge is ensuring the fix does not introduce new issues or complicate the codebase.

Issue Description

Version

v23.6.0

Platform

Linux SMP Debian 5.10.103-1 (2022-03-07) x86_64 x86_64 x86_64 GNU/Linux

Subsystem

No response

What steps will reproduce the bug?

Hi,

I would like to report a bug, it can be reproduced by running the PoC below:

const {exec} = require('child_process');

Object.defineProperty(Array.prototype, "2", {
  set: function () {},
});

(async function () {
  exec('pwd', (err, stdout, stderr) => {
    console.log(stdout);
  });
})();

Regards,

AH

How often does it reproduce? Is there a required condition?

It reproduces anytime by simply running the given PoC on the given Node.js version.

What is the expected behavior? Why is that the expected behavior?

It is a crash.

What do you see instead?

FATAL ERROR: v8::ToLocalChecked Empty MaybeLocal

Additional information

No response

GitHub Labels

child_processc++good first issue

FATAL ERROR: v8::ToLocalChecked Empty MaybeLocal

Why this is a good first issue

AI Summary

Issue Description

Version

Platform

Subsystem

What steps will reproduce the bug?

How often does it reproduce? Is there a required condition?

What is the expected behavior? Why is that the expected behavior?

What do you see instead?

Additional information

GitHub Labels

Want to work on this?

Risk Flags

Details