Skip to main content
GoodFirstPicks
DashboardIssuesReposLeaderboard

GoodFirstPicks by Leaveitblank © 2026

CreatorRequest a RepoPrivacy PolicyTerms of Service
Multiple issues with parsing received emails and storing it in db, then displaying it | GoodFirstPicks

Multiple issues with parsing received emails and storing it in db, then displaying it

frappe/frappe 2 comments 1mo ago
View on GitHub
highopenScope: somewhat clearSkill match: noFrappe / ERPNextPython

Why this is a good first issue

Complex email parsing and display issues require deep system knowledge.

AI Summary

The issue describes multiple problems with email parsing, storage, and display that appear interconnected. It requires refactoring core email handling functionality with security considerations. The scope is broad and touches multiple system components, making it challenging for contributors without deep email protocol and existing codebase knowledge.

Issue Description

Description of the issue

As our company will heavily use emailing feature in frappe, we went for hard-testing of frappe emailing. Currently we found multiple bugs and fixed them, but there is one more and bigger issue. That is, with parsing, storing and then showing the emails. In addition, there is still issue with encoding outgoing emails and decoding subjects/sender. The issue list it:

  • Incorrectly storing email when it includes application/ld+json type (should not include)
  • Completely destroying, destructing and deformatting incoming emails
  • Showing email structure incorrectly/not-formatted
  • Storing email in db in not escaped way in some cases

Why not to create separate issues?

  • I know there is rule, to create separate tickets for each issue, but tbh it would be almost impossible to not to solve one issue with other, because the code for parsing is at the same place of every other issue. Because storing in db and then showing email is in old and bad condition (not correct parsing html, escaping, displaying), it is required to have it refactored and updated (also for better security).
  • In the future, it should be good to allow user to decide if he want to enable/disable external scripts/sources for better security

Resolution?

  • Me with our team, decided that we will solve this issue and propose a fix and refactoring. Will mention created PR.

Context information (for bug reports)

Output of bench version

frappe 15.8.1

Steps to reproduce the issue

  1. Receive email and observe

Observed results screenshots

  • Issue: White text on white background:

    Image
  • Issue: Incorrect position of elements

    Image
  • Issue: Extreme big and inconsistent spaces <img width="1512" alt="Image" src="https://github.c

GitHub Labels

bug

Want to work on this?

Claim this issue to let others know you're working on it. You'll earn 10 points when you complete it!

Risk Flags

  • multiple interconnected issues
  • requires email parsing expertise
  • potential security implications
Loading labels...

Details

Points10 pts
Difficultyhigh
Scopesomewhat clear
Skill Matchno
Test Focusedno
Assigneekrantheman