Skip to main content
GoodFirstPicks
DashboardIssuesReposLeaderboard

GoodFirstPicks by Leaveitblank © 2026

CreatorRequest a RepoPrivacy PolicyTerms of Service
Percent field type: stored value not the correct decimal and no % symbol | GoodFirstPicks

Percent field type: stored value not the correct decimal and no % symbol

frappe/frappe 2 comments 1mo ago
View on GitHub
highopenScope: somewhat clearSkill match: maybeFrappe / ERPNextPython

Why this is a good first issue

Requires schema changes and data migration for Percent field type behavior.

AI Summary

The issue reports incorrect storage and display of Percent field values, requiring both schema changes and data migration. The solution involves modifying how values are stored (as decimals) and displayed (with % symbol), potentially affecting many parts of the codebase. The main blocker is the complexity of safely migrating existing data.

Issue Description

Description of the issue

The decimal value stored for the Percent field type should be the decimal it represents. The value entered is the value stored and displayed just like Float. The % symbol should also be displayed.

Requires a schema change, patch for all Percent fields and potentially a code refactor

Screenshot 2024-10-15 at 13 49 24 Screenshot 2024-10-15 at 13 47 22

Update Jan 2025: I have come across this again in Insights when implementing a calculated column. You have to 'fix' the percentage value by dividing by 100:

Screenshot 2025-01-10 at 18 09 12 Screenshot 2025-01-10 at 18 09 56 Screenshot 2025-01-10 at 18 10 52 Screenshot 2025-01-10 at 18 13 53

Context information (for bug reports)

Output of bench version

frappe: v15.43.0

Observed result

Enter: 20 Display: 20 Store: 20

Expected result

Enter: 20 Display: 20% Store: 0.2

GitHub Labels

bug

Want to work on this?

Claim this issue to let others know you're working on it. You'll earn 30 points when you complete it!

Risk Flags

  • schema change required
  • potential data migration
  • cross-cutting changes
Loading labels...

Details

Points30 pts
Difficultyhigh
Scopesomewhat clear
Skill Matchmaybe
Test Focusedno